Remove error suppression from mysql_*connect()
The suppression was kept so far because mysql_connect(),
mysql_pconnect() emit E_DEPRECATION messages on PHP 5.5+.
Well, we already default to 'mysqli' and there's no reason
to use specifically 'mysql' on PHP 5.5, so we might as well
let the deprecation notices appear and encourage users to
switch drivers.
diff --git a/system/database/drivers/mysql/mysql_driver.php b/system/database/drivers/mysql/mysql_driver.php
index 41cb14b..064cae2 100644
--- a/system/database/drivers/mysql/mysql_driver.php
+++ b/system/database/drivers/mysql/mysql_driver.php
@@ -132,8 +132,8 @@
// Error suppression is necessary mostly due to PHP 5.5+ issuing E_DEPRECATED messages
$this->conn_id = ($persistent === TRUE)
- ? @mysql_pconnect($this->hostname, $this->username, $this->password, $client_flags)
- : @mysql_connect($this->hostname, $this->username, $this->password, TRUE, $client_flags);
+ ? mysql_pconnect($this->hostname, $this->username, $this->password, $client_flags)
+ : mysql_connect($this->hostname, $this->username, $this->password, TRUE, $client_flags);
// ----------------------------------------------------------------